fix: add session.remove() and engine.dispose() to all DB retry paths#574
Merged
fix: add session.remove() and engine.dispose() to all DB retry paths#574
Conversation
update_task_state_with_retry, update_task_progress_with_retry, and _update_failure_diagnostics only called db.session.rollback() on error, reusing the same corrupted connection on every retry attempt. Now each retry discards the session to get a fresh connection, and the pool is disposed when all retries are exhausted. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #573. The
PGRES_TUPLES_OKerror occurs not just intoken_metrics_storebut across all DB operations (update_task_progress_with_retry,update_task_state_with_retry,_update_failure_diagnostics).db.session.rollback()on error, reusing the same corrupted connection on every retry attempt — so all retries faileddb.session.remove()to get a fresh connection from the pooldb.engine.dispose()is called to purge any remaining corrupted connectionsTest plan
🤖 Generated with Claude Code