Add a way to get back to login from forgot-password#117
Add a way to get back to login from forgot-password#117breadddevv merged 9 commits intoPlanetaryOrbit:mainfrom
Conversation
📝 WalkthroughWalkthroughA navigation link labeled "Remember password?" was added to the forgot password page to allow users to return to the login page. The footer layout was restructured from right-aligned to a horizontally spaced arrangement accommodating both the new link and existing continue button. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
pages/forgot-password.tsx (2)
135-143: Fix indentation and consider vertical alignment.The Link on line 136 lacks proper indentation, and the link text may not be vertically centered with the button.
✨ Suggested formatting and alignment fix
<div className="flex gap-3"> -<Link href="/login" className="text-sm text-orbit hover:text-orbit/80 transition-colors">Remember password?</Link> + <Link + href="/login" + className="flex items-center text-sm text-orbit hover:text-orbit/80 transition-colors" + > + Remember password? + </Link> <Button type="submit" classoverride="px-6 py-2.5 text-sm font-medium rounded-xl shadow-sm" > Continue </Button> </div>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pages/forgot-password.tsx` around lines 135 - 143, Fix the markup indentation and vertical alignment for the "Remember password?" Link and Continue Button: properly indent the Link element so it's clearly a sibling of the Button within the same div.flex (the JSX around Link and Button in pages/forgot-password.tsx), and add vertical centering by updating the wrapper div's className to include items-center (e.g., "flex gap-3 items-center") and/or make the Link an inline-flex or add "align-middle" so the link text sits vertically centered with the Button; ensure no other layout classes on Link or Button (e.g., classoverride) conflict with vertical alignment.
135-143: Consider keeping the primary action button right-aligned.Removing
justify-endmoves the "Continue" button from the right to the left side. Convention typically places primary actions on the right. Usingjustify-betweenwould position the link on the left and the button on the right.✨ Suggested layout improvement
- <div className="flex gap-3"> -<Link href="/login" className="text-sm text-orbit hover:text-orbit/80 transition-colors">Remember password?</Link> + <div className="flex items-center justify-between pt-1"> + <Link + href="/login" + className="text-sm text-orbit hover:text-orbit/80 transition-colors" + > + Remember password? + </Link> <Button type="submit" classoverride="px-6 py-2.5 text-sm font-medium rounded-xl shadow-sm"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pages/forgot-password.tsx` around lines 135 - 143, The action row div in pages/forgot-password.tsx currently uses className="flex gap-3" which centers items and moves the primary Button (Continue) to the left; update the div's className to include layout justification (e.g., "flex justify-between gap-3" or "flex justify-end gap-3" depending on desired placement) so the Link stays on the left and the Button (Button component) is right-aligned; ensure the same div wrapping Link and Button is the one updated so styling applies correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pages/forgot-password.tsx`:
- Around line 135-143: Fix the markup indentation and vertical alignment for the
"Remember password?" Link and Continue Button: properly indent the Link element
so it's clearly a sibling of the Button within the same div.flex (the JSX around
Link and Button in pages/forgot-password.tsx), and add vertical centering by
updating the wrapper div's className to include items-center (e.g., "flex gap-3
items-center") and/or make the Link an inline-flex or add "align-middle" so the
link text sits vertically centered with the Button; ensure no other layout
classes on Link or Button (e.g., classoverride) conflict with vertical
alignment.
- Around line 135-143: The action row div in pages/forgot-password.tsx currently
uses className="flex gap-3" which centers items and moves the primary Button
(Continue) to the left; update the div's className to include layout
justification (e.g., "flex justify-between gap-3" or "flex justify-end gap-3"
depending on desired placement) so the Link stays on the left and the Button
(Button component) is right-aligned; ensure the same div wrapping Link and
Button is the one updated so styling applies correctly.
Summary by CodeRabbit