Add rules of engagement for working with JSON schemas agreed by team#14
Merged
PeterBridgerKC merged 2 commits intomainfrom Apr 9, 2024
Merged
Add rules of engagement for working with JSON schemas agreed by team#14PeterBridgerKC merged 2 commits intomainfrom
PeterBridgerKC merged 2 commits intomainfrom
Conversation
PeterBridgerKC
requested review from
ChrisToppingKandC,
DavidJWhiteDev,
beejjacobs,
fabfab-kc and
francescobrenci-AR
beejjacobs
reviewed
Mar 13, 2024
JamesP-KC
approved these changes
Mar 26, 2024
Contributor
JamesP-KC
left a comment
JamesP-KC
left a comment
There was a problem hiding this comment.
All sounds very reasonable to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capturing the agreed rules of working with JSON schemas
Please do push back with suggestions the language isn't clear enough regarding use of nulls, as based on messages I've seen today I think the wording isn't clear enough here