Skip to content

Welsh fields#27

Merged
HadrianHughesKC merged 8 commits intomainfrom
feature/BOAS-1736-welsh
Apr 30, 2024
Merged

Welsh fields#27
HadrianHughesKC merged 8 commits intomainfrom
feature/BOAS-1736-welsh

Conversation

@HadrianHughesKC
Copy link
Copy Markdown
Contributor

@HadrianHughesKC HadrianHughesKC commented Apr 29, 2024 •
edited
Loading

  • Add Welsh fields for nsip-project schema
  • Add Welsh fields to s51-advice schema
  • Add Welsh fields to nsip-document schema
  • Add Welsh fields to nsip-exam-timetable schema
  • Regenerate documentation to include new Welsh fields
  • Regenerate types to include Welsh fields
  • Update Python data models
  • Increment minor version in package.json

BenSurgisonPINS
BenSurgisonPINS approved these changes Apr 30, 2024
View reviewed changes
Copy link
Copy Markdown

@BenSurgisonPINS BenSurgisonPINS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

beejjacobs
beejjacobs requested changes Apr 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@beejjacobs beejjacobs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should allow null for all these new fields
  • We should update the types + python models

Also, as agreed, we will bump the version to 1.1.0

Note field changes have been signed off by the Data Service: https://pins-ds.atlassian.net/browse/BOAS-1736

@HadrianHughesKC HadrianHughesKC force-pushed the feature/BOAS-1736-welsh branch from ac8dc4a to 89181bd Compare April 30, 2024 09:57
beejjacobs
beejjacobs reviewed Apr 30, 2024
View reviewed changes
Comment thread schemas/s51-advice.schema.json Outdated
@HadrianHughesKC HadrianHughesKC force-pushed the feature/BOAS-1736-welsh branch from 89181bd to 676fd5d Compare April 30, 2024 10:52
@HadrianHughesKC HadrianHughesKC force-pushed the feature/BOAS-1736-welsh branch from 676fd5d to 3ae704d Compare April 30, 2024 10:57
beejjacobs
beejjacobs approved these changes Apr 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@beejjacobs beejjacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HadrianHughesKC HadrianHughesKC merged commit da482a3 into main Apr 30, 2024
@HadrianHughesKC HadrianHughesKC deleted the feature/BOAS-1736-welsh branch April 30, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beejjacobs beejjacobs beejjacobs approved these changes

@Maby0 Maby0 Awaiting requested review from Maby0

@DavidJWhiteDev DavidJWhiteDev Awaiting requested review from DavidJWhiteDev

+1 more reviewer

@BenSurgisonPINS BenSurgisonPINS BenSurgisonPINS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HadrianHughesKC @beejjacobs @BenSurgisonPINS