Conversation
f0uriest
approved these changes
Jan 14, 2026
Member
|
Are there any tests we forgot to mark that weren't caught? |
YigitElma
approved these changes
Jan 14, 2026
Collaborator
I ran |
Collaborator
|
On my system, both versions of the script can catch the missing tests (if I delete some existing ones), this might be OS dependent maybe? |
Collaborator
Author
Not that I saw
Hm I ran on macOS. But if the version in this PR works for both linux and macOS I'd prefer this version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
head -n -2was incorrect (-2should just be2), the script was silently failing locally for me (on macOS zsh) and causing it to not actually detect any unmarked tests even if they were present.