Conversation
Collaborator
Author
|
@YigitElma can you check that this works? |
YigitElma
reviewed
Feb 4, 2026
| rcParams["figure.facecolor"] = (1, 1, 1, 1) | ||
| rcParams["figure.figsize"] = (6, 4) | ||
|
|
||
| try: |
Collaborator
There was a problem hiding this comment.
This fixes the problem on my laptop, but can we just remove this whole together. Looks like matplotlib.rcParams has a default value of 100 for the dpi. Do we really need to set it?
Collaborator
Author
There was a problem hiding this comment.
Probably not. let's see how many tests fail if we unset it...
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 6.51 % | 3.806e+03 | 4.054e+03 | 247.86 | 38.78 | 35.85 |
test_proximal_jac_w7x_with_eq_update | -1.64 % | 6.561e+03 | 6.453e+03 | -107.43 | 161.57 | 160.47 |
test_proximal_freeb_jac | 0.14 % | 1.320e+04 | 1.322e+04 | 18.42 | 84.03 | 83.23 |
test_proximal_freeb_jac_blocked | 0.93 % | 7.487e+03 | 7.556e+03 | 69.33 | 73.31 | 72.10 |
test_proximal_freeb_jac_batched | -0.36 % | 7.485e+03 | 7.458e+03 | -27.31 | 72.09 | 74.63 |
test_proximal_jac_ripple | -2.99 % | 3.595e+03 | 3.487e+03 | -107.61 | 65.79 | 65.38 |
test_proximal_jac_ripple_bounce1d | -0.37 % | 3.550e+03 | 3.537e+03 | -12.97 | 77.56 | 75.43 |
test_eq_solve | 2.75 % | 1.993e+03 | 2.048e+03 | 54.89 | 92.57 | 92.76 |For the memory plots, go to the summary of |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2078 +/- ##
==========================================
- Coverage 94.53% 94.51% -0.02%
==========================================
Files 102 102
Lines 28712 28715 +3
==========================================
- Hits 27143 27141 -2
- Misses 1569 1574 +5
🚀 New features to boost your workflow:
|
YigitElma
previously approved these changes
Feb 4, 2026
This reverts commit cfe2181.
YigitElma
approved these changes
Feb 5, 2026
Collaborator
YigitElma
left a comment
There was a problem hiding this comment.
It resolves the problem on WSL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep tk window from opening when
desc.plottingis imported.Resolves #2077