Conversation
unalmis
commented
Mar 31, 2026
| dB_dz, | ||
| dB_dz + jnp.copysign(_eps, dB_dz.real), | ||
| ) | ||
| dz12 = jnp.where(mask, (dp[..., None, :, None] - dB_do) / dB_dz, 0.0) |
Collaborator
Author
There was a problem hiding this comment.
Equation 19 in the supplementary information in publications/unalmis2025.
21 tasks
Adds files to reproduce the results in the article.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splinemethod would require thousands of knots per transit for just a couple digits of accuracy, and it would stop convergence at epsilon<=1e-5 (so sqrt(epsilon) <=3 digits) error due to condition number. Of course, thespline=Falsemethod has always computed the points with spectral accuracy and has very fast convergence after New inverse stream map to accelerate convergence #1919 ; that method converges to epsilon = machine precision without the newton step. With the newton step, fast convergence is achieved with the spline method as well.I did this on a couple lunch breaks, so it would be very weird if clicking the approve button to merge into
mastertook a year.Benchmarks
Here is a timing benchmark on my CPU with
nufft_eps=1e-6. Prior to this PR, every adjoint call to nufft1 took>= 1 secondand the full computation was34 seconds. Now every adjoint call to nufft1 is250 milliseconds, and the full computation is14 seconds. Theseimprovements become largeras thesparsitygrows and error tolerance parameter for the nuffts epsilon tends to 0. Likewise, the improvement grows linearly with theproblem size. As this is called within an optimization loop where time and memory are tight, the improvement is significant.Before
After