Skip to content

fix: integer overflow in calculation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echobt merged 1 commit into from
Jan 8, 2026
+4 −2
Merged

fix: integer overflow in calculation #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/consensus/src/stake_weighted_pbft.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ impl StakeWeightedRoundState {
}
let approve_stake = self.approve_stake();
// Require strictly more than 50% to prevent ties
approve_stake * 2 > total_stake
// Use division instead of multiplication to avoid overflow with large stake values
approve_stake > total_stake / 2
}

/// Check if rejection is certain (>50% reject stake)
Expand All @@ -127,7 +128,8 @@ impl StakeWeightedRoundState {
return false;
}
let reject_stake = self.reject_stake();
reject_stake * 2 > total_stake
// Use division instead of multiplication to avoid overflow with large stake values
reject_stake > total_stake / 2
}

/// Get vote count (for logging)
Expand Down