Skip to content

Fancy IPA Library#625

Merged
Depal1 merged 19 commits intoPlayCover:preview-fancy-libraryfrom
amirsaam:Reworked-Fancy
Jan 16, 2023
Merged

Fancy IPA Library#625
Depal1 merged 19 commits intoPlayCover:preview-fancy-libraryfrom
amirsaam:Reworked-Fancy

Conversation

@amirsaam
Copy link
Copy Markdown
Member

@amirsaam amirsaam commented Dec 24, 2022

Reworked Fancy IPA Library
THIS PR NO LONGER REQUIRES MACOS 13 AS PREVIOUSLY NEEDED

All descriptions already have been given in #588
Separated that PR into multiple parts

  • AppDetailedView base design is from @IsaacMarovitz
  • I reworked it, fixed issues, improved its compatibility, added download states, added locale and etc.

THIS NOTE SHOULD BE READ:

  • New StackNavigationView view extension has been introduced in ViewExtenstions.swift that is similar to NavigationStack on macOS 13 but supports macOS 12.
  • So DetailedView is accessible in macOS 12 with the same code with no if #available statement.

This extension can be used in any other views as you may want.
For example: Creating App Folders in App Library or Source Folders in IPA Library

Co-Authored-By: Isaac Marovitz 42140194+IsaacMarovitz@users.noreply.github.com

@amirsaam amirsaam marked this pull request as ready for review December 29, 2022 22:39
@IsaacMarovitz
Copy link
Copy Markdown
Member

Needs rebase

@amirsaam
Copy link
Copy Markdown
Member Author

amirsaam commented Jan 4, 2023

Needs rebase

Elaborate please.

@zanderp25 zanderp25 added the enhancement New feature or request label Jan 8, 2023
@Depal1 Depal1 added help wanted / caution Extra attention is needed UI User interface related changes squash Indicates whether a PR must be squashed before being merged labels Jan 14, 2023
@Depal1 Depal1 changed the base branch from develop to preview-fancy-library January 16, 2023 23:41
@Depal1 Depal1 merged commit caeb65e into PlayCover:preview-fancy-library Jan 16, 2023
@amirsaam amirsaam deleted the Reworked-Fancy branch January 17, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted / caution Extra attention is needed squash Indicates whether a PR must be squashed before being merged UI User interface related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants