Refactor meme-game and viral-game to use the make-game pipelines#27
Draft
M4cs wants to merge 2 commits into
Draft
Refactor meme-game and viral-game to use the make-game pipelines#27M4cs wants to merge 2 commits into
M4cs wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two things in one PR:
/meme-game is a focused skill that swaps named entities in an existing game for photo-composite public
figures (Trump, Altman, Musk, etc.) and wires reactive expressions to game events. It can be
auto-invoked by /viral-game when a public figure is detected, or run standalone (/meme-game
).
introduced by /make-game v2. Same structural shape across all three skills.
Why
/viral-game (the renamed-by-#26 old monolithic make-game) was a 650-line SKILL.md of rigid Step 0..5.5
prose with "wait for user confirmation between every step" sprinkled through it. /meme-game from #22 was
useful but lived as a separate skill with duplicated public-figure detection logic and a /make-game
hand-off contract that no longer matched main's structure.
Both skills now use the same playbook: slim SKILL.md, finite rules, named phases, reusable
sub-pipelines, minimum-viable docs by default, pause only at phase boundaries.
What changed
New: /meme-game skill (cherry-picked from #22, then refactored)
skills/meme-game/
SKILL.md # Slim: rules + phase index
phases/
audit.md # Read project, identify entities, resolve slug list
resolve.md # 5-tier 2D / 4-tier 3D fallback per slug
wire.md # Bobblehead + expressions (2D) / SkeletonUtils (3D)
verify.md # Build + visual + expression spot-check + tests
sub-pipelines/
public-figure-detection.md # SHARED detection logic (referenced by viral-game too)
character-resolution-2d.md # 5-tier photo-composite flow
character-resolution-3d.md # 4-tier Meshy/library/Sketchfab flow
expression-wiring.md # Event → expression mapping
Refactored: /viral-game
skills/viral-game/
SKILL.md # Slim: rules + phase index (was 650-line monolith)
phases/
concept.md # Form A/B parsing, public-figure detection, 2 questions, slim docs
scaffold.md # Template copy, install, transform subagent, verify
build.md # 7 conditional tasks with verification (gateables → assets →
meme-pass → design → promo → audio → QA)
ship.md # Deploy → monetize → review → graduation hand-back
sub-pipelines/
verification.md # (renamed from verification-protocol.md)
step-details.md # Subagent prompt templates (content unchanged)
tweet-pipeline.md # Form B + reference to shared detection
live-iterate.md # Borrowed from /make-game v2
templates/
gameplan-slim.md # 1-page auto-fillable, /make-game-schema-compatible
state.md # docs/STATE.md skeleton (shared with /make-game)
Pulled from PR #22
game-designer/, meshyai, phaser/project-setup
placeholders), and Step 1.6 /meme-game hand-off — re-targeted onto /viral-game since main's /make-game
is the v2 phase-based skill
Skipped from PR #22
both skills coexist)
Consistency contracts
Both skills hold to the same rules:
Single source of truth for public-figure detection lives at
skills/meme-game/sub-pipelines/public-figure-detection.md. viral-game/SKILL.md,
viral-game/sub-pipelines/tweet-pipeline.md, and agents/game-creator.md all reference it instead of
duplicating.
Graduation path
/viral-game's output is /make-game-compatible by design. docs/STATE.md and docs/gameplan.md use the same
schema as /make-game's templates. A user who outgrows the one-shot model can run /make-game against the
same directory in their next session — no file rewrites.
Regression case to watch
/viral-game 2d maze-tank (or any generic prompt that names no real people) must stay purely generic — no
public figures injected anywhere, no Expression Map in docs/gameplan.md, no assets/characters/ copy, no
/meme-game invocation. This is the case the old monolithic pipeline got wrong; the architectural
commitment is to keep it generic.
Test plan
Files
23 files touched. New: 13 (4 meme-game phase docs, 4 viral-game phase docs, 1 shared detection
sub-pipeline, 2 viral-game templates, 1 borrowed live-iterate, 1 meme-game SKILL.md). Modified: 8 (3
cherry-picked rename pass + viral-game SKILL/step-details/tweet-pipeline rewrites + CLAUDE.md +
agents/game-creator.md). Renamed: 3 (viral-game's old top-level companions moved into sub-pipelines/).
No deletions of pre-existing user-visible files.