fix(plugin-registry): read additional_encodings from parser manifests#18
Merged
pabloinigoblasco merged 1 commit intoApr 2, 2026
Merged
Conversation
The host only read the primary 'encoding' field from plugin manifests. Parsers that declare encoding aliases under 'additional_encodings' (e.g., the ROS parser exposing 'ros1'/'ros2' alongside 'ros2msg') were not registered for those encodings, causing MCAP channels with those encoding values to fail parser binding at import time. This fix registers all declared encodings so that: - `encoding`: primary encoding (e.g., "ros2msg") - `additional_encodings`: aliases (e.g., ["ros1msg", "cdr", "ros1", "ros2"]) Both get added to the parser's registered encodings list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The host only read the primary
encodingfield from plugin manifests. Parsers that declare encoding aliases underadditional_encodingswere not registered for those encodings, causing import failures for files using those encodings.Problem: MCAP files with
messageEncoding: "ros1"(instead of the canonical"ros1msg") fail to import because no parser is registered for that encoding.Solution: Read both
encodingandadditional_encodingsfrom the manifest and register the parser for all declared encodings.Technical Details
Parser manifests can declare:
encoding: primary encoding (e.g.,"ros2msg")additional_encodings: aliases (e.g.,["ros1msg", "cdr", "ros1", "ros2"])Both fields now get added to the parser's registered encodings list in
PluginRegistry::tryLoadMessageParser().Related
"ros1"and"ros2"toadditional_encodingsinparser_ros/manifest.jsonFiles Changed
pj_proto_app/src/plugin_registry.cpp— readadditional_encodingsfield