Skip to content

feat(sdk): add showMessageBox to DataSource runtime host API#24

Merged
pabloinigoblasco merged 1 commit into
developmentfrom
feat/sdk-show-message-box
Apr 1, 2026
Merged

feat(sdk): add showMessageBox to DataSource runtime host API#24
pabloinigoblasco merged 1 commit into
developmentfrom
feat/sdk-show-message-box

Conversation

@pabloinigoblasco
Copy link
Copy Markdown
Collaborator

@pabloinigoblasco pabloinigoblasco commented Apr 1, 2026

Summary

Extends the DataSource SDK with modal message box support, allowing plugins to display info/warning/error/question dialogs during data loading or streaming.

Changes

C ABI (data_source_protocol.h):

  • PJ_message_box_type_t enum: Info, Warning, Error, Question
  • PJ_message_box_buttons_t flags: Ok, Cancel, Yes, No, Continue, Abort, Retry, Ignore
  • show_message_box function in runtime host vtable

C++ SDK (data_source_plugin_base.hpp):

  • MessageBoxType and MessageBoxButton enums
  • DataSourceRuntimeHostView::showMessageBox() with typed return
  • Convenience: showInfo, showWarning, showError
  • Decision helpers: askContinue, askYesNo

Protoapp:

  • ShowMessageBoxCallback in RuntimeHostState
  • makeMessageBoxCallback() factory using QMessageBox
  • Callback bound to sessions before start

Test plan

  • 46/46 tests pass
  • Build compiles with -Wall -Wextra -Werror
  • Manual test with plugin showing warnings

@pabloinigoblasco pabloinigoblasco force-pushed the feat/sdk-show-message-box branch 2 times, most recently from 4501dbd to 358b3d0 Compare April 1, 2026 11:25
Extends the DataSource SDK with modal message box support, allowing
plugins to display info/warning/error/question dialogs to users during
data loading or streaming operations.

C ABI additions (data_source_protocol.h):
- PJ_message_box_type_t enum (Info, Warning, Error, Question)
- PJ_message_box_buttons_t flags (Ok, Cancel, Yes, No, etc.)
- show_message_box function in runtime host vtable

C++ SDK additions (data_source_plugin_base.hpp):
- MessageBoxType and MessageBoxButton enums
- DataSourceRuntimeHostView::showMessageBox() with typed return
- Convenience methods: showInfo, showWarning, showError
- Decision helpers: askContinue, askYesNo

Protoapp implementation:
- RuntimeHostState callback pattern for Qt binding
- makeMessageBoxCallback() factory using QMessageBox
- Callback bound to sessions before start
@pabloinigoblasco pabloinigoblasco force-pushed the feat/sdk-show-message-box branch from 358b3d0 to 028cd79 Compare April 1, 2026 11:36
@pabloinigoblasco pabloinigoblasco merged commit 9f2c18e into development Apr 1, 2026
2 checks passed
@pabloinigoblasco pabloinigoblasco deleted the feat/sdk-show-message-box branch May 4, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant