Skip to content

fix(marketplace): correct category filter values #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloinigoblasco merged 2 commits into from
Apr 3, 2026
Merged

fix(marketplace): correct category filter values #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
118af57
fix(marketplace): correct category filter values to match manifest co…
pabloinigoblasco Apr 2, 2026
9974ec0
fix(marketplace): remove empty changelog section and rename GitHub bu…
pabloinigoblasco Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions pj_marketplace/src/ui/extension_detail_dialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,6 @@ ExtensionDetailDialog::ExtensionDetailDialog(const Extension& ext, const QString
// ── Description ────────────────────────────────────────────────────────────
ui_->desc_lbl->setText(ext.description);

// ── Changelog ──────────────────────────────────────────────────────────────
QString changelog_html;
const auto keys = ext.changelog.keys();
for (int i = static_cast<int>(keys.size()) - 1; i >= 0; --i) {
const QString& ver = keys[i];
changelog_html += "<b>v" + ver + "</b><br/>";
changelog_html += ext.changelog[ver] + "<br/><br/>";
}
ui_->changelog_browser->setHtml(changelog_html);

// ── Buttons ── state-dependent visibility and style ────────────────────────
const bool installed = !installed_version.isEmpty();
const bool has_update = installed && installed_version != ext.version;
Expand Down
35 changes: 1 addition & 34 deletions pj_marketplace/src/ui/extension_detail_dialog.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,39 +76,6 @@
</widget>
</item>

<!-- Separator -->
<item>
<widget class="QFrame" name="separator2">
<property name="frameShape"><enum>QFrame::HLine</enum></property>
<property name="frameShadow"><enum>QFrame::Sunken</enum></property>
</widget>
</item>

<!-- Changelog section -->
<item>
<widget class="QLabel" name="changelog_header">
<property name="text"><string>Changelog</string></property>
<property name="styleSheet">
<string notr="true">font-weight: bold; color: palette(mid);</string>
</property>
</widget>
</item>
<item>
<widget class="QTextBrowser" name="changelog_browser">
<property name="maximumSize">
<size><width>16777215</width><height>120</height></size>
</property>
<property name="frameShape"><enum>QFrame::NoFrame</enum></property>
<property name="openLinks"><bool>false</bool></property>
<property name="styleSheet">
<string notr="true">QTextBrowser { background: palette(alternate-base);
border: 1px solid palette(mid);
border-radius: 4px;
padding: 6px; }</string>
</property>
</widget>
</item>

<!-- Vertical stretch -->
<item>
<spacer name="main_stretch">
Expand All @@ -122,7 +89,7 @@
<layout class="QHBoxLayout" name="btn_layout">
<item>
<widget class="QPushButton" name="github_btn">
<property name="text"><string>View on GitHub</string></property>
<property name="text"><string>Visit Website</string></property>
<property name="styleSheet">
<string notr="true">QPushButton { border: 1px solid palette(mid); border-radius: 4px; padding: 4px 14px; }
QPushButton:hover { background: palette(mid); }
Expand Down
11 changes: 5 additions & 6 deletions pj_marketplace/src/ui/marketplace_window.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,11 @@ void MarketplaceWindow::setupUi() {
ui_->update_all_btn_->setFixedWidth(90);
ui_->update_all_btn_->setEnabled(false);

ui_->category_combo_->addItem("All categories", "");
ui_->category_combo_->addItem("Data Loader", "data_loader");
ui_->category_combo_->addItem("Data Streamer", "data_streamer");
ui_->category_combo_->addItem("Parser", "parser");
ui_->category_combo_->addItem("Toolbox", "toolbox");
ui_->category_combo_->addItem("Bundle", "bundle");
ui_->category_combo_->addItem("All categories", "");
ui_->category_combo_->addItem("Data Loader", "data_loader");
ui_->category_combo_->addItem("Data Streamer", "data_stream");
ui_->category_combo_->addItem("Message Parser", "message_parser");
ui_->category_combo_->addItem("Toolbox", "toolbox");

connect(ui_->search_edit_, &QLineEdit::textChanged,
this, &MarketplaceWindow::onSearchChanged);
Expand Down
Loading