Skip to content

fix(protoapp): always call loadConfig for streaming sources #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloinigoblasco merged 2 commits into from
Apr 4, 2026
Merged

fix(protoapp): always call loadConfig for streaming sources #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b4e34e
fix(protoapp): always call loadConfig for streaming sources
pabloinigoblasco Apr 3, 2026
aa17687
fix(plugins): add RTLD_DEEPBIND to prevent OpenSSL symbol conflicts
pabloinigoblasco Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pj_plugins/src/detail/library_loader.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ inline Expected<void*> loadLibraryHandle(std::string_view path) {
}
return reinterpret_cast<void*>(module);
#else
void* handle = dlopen(std::string(path).c_str(), RTLD_NOW | RTLD_LOCAL);
void* handle = dlopen(std::string(path).c_str(), RTLD_NOW | RTLD_LOCAL | RTLD_DEEPBIND);
if (handle == nullptr) {
return unexpected(std::string(dlerror()));
}
Expand Down
7 changes: 3 additions & 4 deletions pj_proto_app/src/main_window.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,10 +354,9 @@ void MainWindow::onStartStream() {
// Bind runtime host early so the dialog can call listAvailableEncodings()
session->bindRuntimeHostForDialog();

// Restore saved config so the dialog remembers previous choices
if (!saved_config.empty()) {
(void)session->handle().loadConfig(saved_config);
}
// Always call loadConfig() so the plugin can initialize (e.g., populate encodings list)
// even if there's no saved config yet
(void)session->handle().loadConfig(saved_config);

// Dialog flow — use the session's own handle, not a temp handle
std::string config = saved_config;
Expand Down
Loading