feat(proto-app): add Tools menu with dynamic toolbox plugin discovery#55
Merged
Conversation
Add a Tools menu to MainWindow that dynamically discovers and lists all loaded Toolbox plugins. Each plugin appears as a menu action that opens its dialog via ToolboxSession::runDialog(). After the dialog closes, the chart and series tree are refreshed. This is the minimum wiring needed to open toolbox plugins (FFT, Quaternion, ColorMap, etc.) from the application UI.
toolbox_session.cpp was added by PR #44 but not listed in the CMakeLists.txt sources, causing undefined reference errors at link time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Without this change, there is no way to open toolbox plugins (FFT, Quaternion, ColorMap, etc.) from the application UI. The
ToolboxSessionandPluginRegistryinfrastructure exists, but nothing inMainWindowwires them to the user interface.In PJ 3.x, toolbox plugins appear under a "Tools" menu. This PR adds the equivalent to proto_app.
Summary
MainWindowviamenuBar()->addMenu("&Tools")setupToolboxPanels()iteratesregistry_.allToolboxes(), creates aToolboxSessionper plugin, and adds a menu action that opens the plugin's dialog viarunDialog()Test plan
pj_proto_app— no compile errors.soplugin in the plugin directory — it appears in the Tools menu