fix(dialog-sdk): disable acceptDrops on ChartPreviewWidget for DropEventFilter compatibility#58
Merged
Conversation
…entFilter compatibility QGraphicsView (parent of QChartView/ChartPreviewWidget) enables acceptDrops by default. This causes it to consume drag-drop events silently, preventing them from reaching the dialog-level DropEventFilter. Disable acceptDrops on both the widget and its viewport in the constructor so drag events propagate to the parent QFrame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QGraphicsView (parent of QChartView/ChartPreviewWidget) enables
acceptDropsby default. This causes it to consume drag-drop events silently, preventing them from reaching the dialog-level DropEventFilter.Fix: disable
acceptDropson both the widget and its viewport in the constructor, so drag events propagate to the parent QFrame where the DropEventFilter can handle them.Discovered when porting the FFT toolbox — drag-drop onto the input chart area didn't work because QGraphicsView was eating the events.
Test plan