fix(cmake): build pj_media inside PJ_BUILD_DATASTORE guard#70
Merged
Conversation
pj_media_core depends on pj_datastore (object_store.hpp), so it cannot build when PJ_BUILD_DATASTORE=OFF. Moving the three pj_media add_subdirectory calls inside the existing PJ_BUILD_DATASTORE block expresses the real dependency: media requires the datastore, and consumers that opt out of the datastore (e.g. plugin-only builds) no longer hit a missing-header failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pj_media_coredepends onpj_datastore(object_store.hpp), but the threeadd_subdirectory(pj_media/...)calls were unconditional — outside theif(PJ_BUILD_DATASTORE)block. When consumers build withPJ_BUILD_DATASTORE=OFF(e.g. plugin-only builds via CPM), the datastore include directories are not available andpj_media_corefails with a missing-header error.Fix: move the
pj_mediasubdirectories inside the existingPJ_BUILD_DATASTOREguard. This expresses the real architectural dependency: media requires the datastore. Consumers that opt out of the datastore no longer hit the build failure.Test plan
PJ_BUILD_DATASTORE=ON): datastore + media both compile as beforePJ_BUILD_DATASTORE=OFF): neither datastore nor media are built, no errors