Expose setters for undistortion parameters in Andor device#756
Merged
adamrankin merged 3 commits intoPlusToolkit:masterfrom Jan 6, 2021
Merged
Expose setters for undistortion parameters in Andor device#756adamrankin merged 3 commits intoPlusToolkit:masterfrom
adamrankin merged 3 commits intoPlusToolkit:masterfrom
Conversation
dzenanz
approved these changes
Jan 5, 2021
Contributor
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Looks good, in-line suggestion.
| } | ||
|
|
||
| // ---------------------------------------------------------------------------- | ||
| PlusStatus vtkPlusAndorVideoSource::SetCameraIntrinsics(double* intrinsics) |
Contributor
There was a problem hiding this comment.
Style-wise and from type safety standpoint, it might be better to use std::vector<double> or std::array<double, 9>. Possibly also update ivar to be the same type.
Contributor
Author
There was a problem hiding this comment.
Thanks, pushed a change for this. I left the internal var as is, because I wasn't sure how to handle Set/GetVectorAttribute nicely in Read/WriteConfiguration which was complaining about expecting double *s.
adamaji
force-pushed
the
andor-undistortion
branch
from
4715427 to
40a0d60
Compare
dzenanz
approved these changes
Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes setters/getters for camera intrinsics and distance coefficients for the Andor device, since these parameters must be changed for different binning settings.
Other small changes are converting the units for processed Andor images into counts/seconds and fixing a bug where correction images are loaded as the wrong type.
cc @jrojasUNC @dzenanz for review