Resolving last issues with remote control of Capistrano device#812
Resolving last issues with remote control of Capistrano device#812Sunderlandkyl merged 4 commits intoPlusToolkit:masterfrom
Conversation
This is similar to Interson implementation.
Since Capistrano implementation ignores these parameters, if they are not set in configuration files they cause problems for remote command execution. So we initialize them in constructor.
It is covered by standardized image parameter FrequencyMhz. This affects how it is specified in the configuration files.
|
Does this need to be tested with hardware? |
|
I already tested it, and it works for me. But I would prefer if @jamesobutler or @adamaji confirmed it works for them too. |
|
Yes I should test with Hardware. I will be able to do this next week after the Federal holiday on Monday. |
jamesobutler
left a comment
jamesobutler
left a comment
There was a problem hiding this comment.
I was able to test using the UltrasoundRemoteControl module in 3D Slicer. I was able to observe Capistrano imaging depth and frequency appropriately updating.
For UltrasoundRemoteControl I had to make a minor update to allow higher frequencies as it currently supports 2-5 MHz as defined here while the Capistrano API supports up to 50 MHz as an option. It is also difficult to use the sliders for that module, but that's an area of improvement for that module and not PlusLib. @Sunderlandkyl Have you used this module recently and identified possible areas of improvement?
|
I haven't used it recently, but there are several projects that use qSlicerUltrasoundDoubleParameterSlider to change ultrasound parameters. What difficulty did you have with the Sliders? |
|
Frequency slider was limited to 2-5 while my device supports 10-50. It also supports discrete values rather than continuous for frequency and imaging depth. Typing the value into the spinboxes next the to the slider would often get rejected due to typing a 2 digit number resulting in it get rejected when the first digit was entered. I really had to drag the slider and then let it go over a valid value to trigger the update. |
4 participants
This should make it possible to work without warnings even if not all parameters are specified in the config file. There will be companion PlusLibData PR.
CC: @jamesobutler.