Improved Python Support for Aurora wired tools.#18
Improved Python Support for Aurora wired tools.#18adamrankin merged 1 commit intoPlusToolkit:masterfrom
Conversation
Added ndiTX, ndiGetTXTransform, ndiGetTXPortStatus, ndiGetTXSystemStatus, ndiGetTXFrame, ndiGetPHSRNumberOfHandles, and ndiGetPHSRHandle to Python module
| &_ndiConverter, &pol, &port)) | ||
| { | ||
| result = ndiGetGXPortStatus(pol, port); | ||
| result = ndiGetBXPortStatus(pol, port); |
There was a problem hiding this comment.
I am not familiar with the GX calls, but is this correct?
There was a problem hiding this comment.
I'm not sure. I haven't used Py_ndiGetBXPortStatus in my application. I noticed when I was doing a find and replace that Py_ndiGetBXPortStatus called ndiGetGXPortStatus, which looked like a typo to me. We should check with @eruffaldi and I'll test it on one of my trackers.
There was a problem hiding this comment.
I just checked using our Polaris Vega. I think it was a bug, i.e. Py_ndiGetBXPortStatus always returns zero for me without this change, with this change I get an appropriate return value (49).
There was a problem hiding this comment.
sigh Sorry, that's my fault. Github diff shrunk the code between ndiGetGX and ndiGetBX so I thought you were changing GX to BX... disregard all of this.
2 participants
Added ndiTX, ndiGetTXTransform, ndiGetTXPortStatus, ndiGetTXSystemStatus, ndiGetTXFrame, ndiGetPHSRNumberOfHandles, and ndiGetPHSRHandle to Python module