This repository was archived by the owner on Jan 29, 2026. It is now read-only.
more deployment bugfixes - remove all cdktf array syntax#44
Merged
hyperparabolic merged 1 commit intomainfrom Apr 27, 2023
Merged
more deployment bugfixes - remove all cdktf array syntax#44hyperparabolic merged 1 commit intomainfrom
hyperparabolic merged 1 commit intomainfrom
Conversation
Remove all array syntax for all of mozillaOpsSourceRule waf rule. I'm not sure why type checking is failing so badly here, but I think it might be related to not having cdktf declared as a dependency, and just implicitly inheriting it from terraform-modules. Removed every array other than textTransformation (it contains priorities, which suggests it needs to be an array).
bassrock
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #42, #43 for more details.
Remove all array syntax for all of mozillaOpsSourceRule waf rule.
I'm not sure why type checking is failing so badly here, but I think it might be related to not having cdktf declared as a dependency, and just implicitly inheriting it from terraform-modules.
Removed every array other than textTransformation (it contains priorities, which suggests it needs to be an array).
Goal
Hopefully deploy
I'd love feedback/perspectives on:
Implementation Decisions
N/A
Deployment steps
N/A
References
N/A