This repository was archived by the owner on Jan 29, 2026. It is now read-only.
feat(Recommendations): Rename operation to NewTabRecommendations#50
Merged
feat(Recommendations): Rename operation to NewTabRecommendations#50
Conversation
We use the operation name to identify operations in Apollo Studio, and it would be helpful if this operation had a more distinct name.
bassrock
approved these changes
Jun 5, 2023
jpetto
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Give a more distinct, meaningful name to the operation that queries recommendations for NewTab, such that this operation can be distinguished in Apollo Studio and Sentry from other operations that query recommendations.
I'd love feedback/perspectives on:
References
JIRA ticket: