Skip to content

feat(recommendations): [DIS-648] Add locales & regions #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 7, 2023
Merged

feat(recommendations): [DIS-648] Add locales & regions #52

merged 4 commits into from
Jul 7, 2023

Conversation

@mmiermans
Copy link
Contributor

@mmiermans mmiermans commented Jun 9, 2023 •
edited
Loading

Goal

Unblock Firefox 116 Nightly from switching to this API for NewTab recommendations in existing markets.

Implementation Decisions

  • I'm a bit out of my comfort zone in this repo, so I did not make any effort to avoid duplicating locales & regions. My main hope was that making a start with this change would be helpful.

Deployment steps

PRs that need to be deployed before this PR:

  • #393 Snowflake tests do not fail for Firefox locales.
  • #201 Snowplow schema accepts Firefox locales.
  • #1046 Recommendation-api maps locale & region to the right market.

References

JIRA ticket:

Documentation:

@mmiermans mmiermans requested a review from ScottDowne June 9, 2023 20:27
@mmiermans mmiermans requested review from a team as code owners June 9, 2023 20:27
@mmiermans mmiermans requested review from cmharlow, hyperparabolic and katerinachinnappan and removed request for cmharlow and katerinachinnappan June 9, 2023 20:27
hyperparabolic
hyperparabolic approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@hyperparabolic hyperparabolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mmiermans mmiermans merged commit b38a860 into main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScottDowne ScottDowne ScottDowne approved these changes

+1 more reviewer

@hyperparabolic hyperparabolic hyperparabolic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmiermans @ScottDowne @hyperparabolic