(chore) Remove code that was commented out during the recent incident #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efixler
commented
Feb 21, 2024
| Url: any; | ||
| }; | ||
|
|
||
| /** |
Contributor
Author
There was a problem hiding this comment.
These changes all arrived here as part of the codegen step of the build. I assume that these are derived from some sort of introspection on the graph. They neither look harmless, nor do they seem directly relevant to the intent of this PR; if folks with better understanding of the graph semantics can advise, I'd appreciate. Happy to punt on this PR is this is questionable.
Contributor
There was a problem hiding this comment.
These appear to be updates to the graph made by the Pocket team recently. They're all additive changes, too, which means they won't affect anything this proxy relies on.
nina-py
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
During a recent NewTab incident I commented out code that populated TimeToRead.
This PR just deletes these comments.
I've left other code referencing TimeToRead in place for now and ticketed a deeper removal task for the future.
I don't have a great way to include steps to test here, but this PR should have been a noop -- there are, however, significant changes to GraphQL types that came about as a result of codegen would appreciate 👀 on that.