fix: upgrade Node to the latest on the 18 release line #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmiermans
force-pushed
the
mc-942-upgrade-node
branch
from
6e75abe to
76314de
Compare
mmiermans
commented
Apr 11, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM node:18-slim@sha256:0a621cdd7d66ad8976f4246ab0661e3b1dd0d397c1dd784ea01bf740bd1c2522 | |||
| FROM node:18@sha256:332838eb5ed61f24f5f68e3e465453d82ea8cd8870d9875325f20706880ae9fc | |||
Contributor
Author
There was a problem hiding this comment.
Unless you are working in an environment where only the node image will be deployed and you have space constraints, we highly recommend using the default image of this repository.
mmiermans
commented
Apr 11, 2024
| description: Run spec tests | ||
| docker: | ||
| - image: cimg/node:18@sha256:45826c38fb365c2848f3f595443b3086b1df4256d659b380bb9b666141eceadd | ||
| - image: cimg/node:18.20 |
Contributor
Author
There was a problem hiding this comment.
I think this change fixed the NO_PUBKEY errors in CI.
nina-py
reviewed
Apr 11, 2024
| "scripts": { | ||
| "build": "rm -rf dist && tsc", | ||
| "codegen": "npm run codegen:graphql-types && npm run codegen:openapi-types", | ||
| "codegen": "npm run codegen:graphql-types", |
Contributor
There was a problem hiding this comment.
Is a combined job to run both scripts not needed any more? I think it's used by a pre-commit hook
Contributor
Author
There was a problem hiding this comment.
Forgot to add an item under 'additional changes':
pre-commit failed on the OpenAPI validation, so I disabled that. I created MC-952 in the maintenance backlog to turn this back on.
nina-py
approved these changes
Apr 11, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
MC-942 Update Node to the latest version on the v20.x release line.
Additional changes
pre-commit failed on the OpenAPI validation, so I disabled that. I created MC-952 in the maintenance backlog to turn this back on.
To resolve an error during
apt-get update, I changed the CI image to the latest of 18, and switched to the default Node image.QA
Local
Run
npm run start:devDev