Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Sub/Queue/SqsSnsQueue.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ public function later($delay, $job, $data = '', $queue = null)
*/
public function pop($queue = null)
{
$queue = $this->getQueue($queue);

$response = $this->sqs->receiveMessage([
'QueueUrl' => $this->getQueue($queue),
'QueueUrl' => $queue,
'AttributeNames' => ['ApproximateReceiveCount'],
]);

Expand Down
19 changes: 19 additions & 0 deletions tests/Sub/Queue/SqsSnsQueueTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,31 @@ public function it_can_receive_a_rich_notification_message_and_pop_it_off_the_qu
{
$this->sqs->shouldReceive('receiveMessage')
->once()
->with(['QueueUrl' => '/default', 'AttributeNames' => ['ApproximateReceiveCount']])
->andReturn($this->mockedRichNotificationMessage());

$queue = new SqsSnsQueue($this->sqs, 'default');
$queue->setContainer($this->app);
$result = $queue->pop();

$this->assertInstanceOf(SnsEventDispatcherJob::class, $result);
$this->assertEquals('/default', $result->getQueue());
}

/** @test */
public function it_should_use_the_queue_name_including_prefix_and_suffix()
{
$this->sqs->shouldReceive('receiveMessage')
->once()
->with(['QueueUrl' => 'prefix/default-suffix', 'AttributeNames' => ['ApproximateReceiveCount']])
->andReturn($this->mockedRichNotificationMessage());

$queue = new SqsSnsQueue($this->sqs, 'default', 'prefix', '-suffix');
$queue->setContainer($this->app);
$result = $queue->pop();

$this->assertInstanceOf(SnsEventDispatcherJob::class, $result);
$this->assertEquals('prefix/default-suffix', $result->getQueue());
}

/** @test */
Expand Down