Skip to content

Change Time::MIN to Time::MIN_VALUE to match DateTime #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wrieg123 merged 1 commit into from
Sep 29, 2024
Merged

Change Time::MIN to Time::MIN_VALUE to match DateTime #362

wrieg123 merged 1 commit into from
Sep 29, 2024

Conversation

@wrieg123
Copy link
Collaborator

@wrieg123 wrieg123 commented Sep 29, 2024

Semantically align the "minimum" value for Time with DateTime & TimeDelta (e.g. ::MIN_VALUE). Also, this avoids conflicts with other headers that rely on a MIN macro.

@wrieg123
Change Time::MIN to Time::MIN_VALUE to match DateTime
fc04358 
Signed-off-by: Will Rieger <will.r.rieger@gmail.com>
@wrieg123 wrieg123 requested a review from timkpaine September 29, 2024 13:58
@timkpaine timkpaine added type: enhancement Issues and PRs related to improvements to existing features lang: c++ Issues and PRs related to the C++ codebase labels Sep 29, 2024
@wrieg123 wrieg123 merged commit 9da93f1 into Point72:main Sep 29, 2024
@wrieg123 wrieg123 deleted the change-time-min branch November 11, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robambalu robambalu robambalu approved these changes

@timkpaine timkpaine Awaiting requested review from timkpaine

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

Assignees

No one assigned

Labels

lang: c++ Issues and PRs related to the C++ codebase type: enhancement Issues and PRs related to improvements to existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wrieg123 @robambalu @timkpaine