Make all public classes of CSP visible for user extension modules #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGlustein
requested review from
alexddobkin,
ptomecek,
robambalu,
svatasoiu and
timkpaine
as code owners
AdamGlustein
force-pushed
the
fix-symbol-visibility-for-user-extensions
branch
from
78e4af3 to
5cc011e
Compare
robambalu
requested changes
Oct 2, 2024
Collaborator
robambalu
left a comment
robambalu
left a comment
There was a problem hiding this comment.
Can we also add a build / test of a user extension node and adapter as part of this
timkpaine
reviewed
Oct 2, 2024
… struct cpp example Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com>
…cess them Signed-off-by: Adam Glustein <adam.glustein@point72.com>
AdamGlustein
force-pushed
the
fix-symbol-visibility-for-user-extensions
branch
from
5cc011e to
49a7bfa
Compare
…bol-visibility-for-user-extensions
Signed-off-by: Adam Glustein <adam.glustein@point72.com>
AdamGlustein
force-pushed
the
fix-symbol-visibility-for-user-extensions
branch
from
7fba64b to
5414d97
Compare
timkpaine
reviewed
Oct 16, 2024
| set(__csp_base_path "${CMAKE_SOURCE_DIR}/csp") | ||
| set(__csp_include_path "${CMAKE_SOURCE_DIR}/cpp") | ||
| set(__csp_lib_path "${CMAKE_SOURCE_DIR}/") | ||
| set(__csp_base_path "${CMAKE_SOURCE_DIR}/csp") |
Member
There was a problem hiding this comment.
duplicate with line 35 and the next line, i mustve had a stroke while writing this
Signed-off-by: Adam Glustein <adam.glustein@point72.com>
AdamGlustein
force-pushed
the
fix-symbol-visibility-for-user-extensions
branch
from
796bb6a to
9c171f0
Compare
Signed-off-by: Adam Glustein <adam.glustein@point72.com>
Collaborator
Author
|
Going to try a new approach to get this working for mac and linux and leave Windows extension node visibility as a TO-DO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #363