Skip to content

Conversation

@timkpaine
Copy link
Member

@timkpaine timkpaine commented Feb 14, 2024

This PR builds on #83 and attempts to reenable vector<bool> by targeted specialization of functions that would've resulted in bit references.

It fails the same tests as #83 , but is probably closer to the end solution. The failing tests are almost all pandas related

FAILED csp/tests/impl/test_dateframe.py::TestCspDataFrame::test_math_ops - AssertionError: False is not true
FAILED csp/tests/impl/test_pandas_ext_type.py::TestBooleanReduce::test_reduce_series_boolean[all-True] - AssertionError: Input are different
FAILED csp/tests/impl/test_pandas_ext_type.py::TestBooleanReduce::test_reduce_series_boolean[all-False] - AssertionError: Input are different
FAILED csp/tests/impl/test_pandas_ext_type.py::TestBooleanReduce::test_reduce_series_boolean[any-True] - AssertionError: Input are different
FAILED csp/tests/impl/test_pandas_ext_type.py::TestBooleanReduce::test_reduce_series_boolean[any-False] - AssertionError: Input are different
FAILED csp/tests/impl/test_pandas_perspective.py::TestCspPerspectiveTable::test_run_types - AssertionError: Series are different
FAILED csp/tests/test_history.py::TestHistory::test_range_access - AssertionError: dtype('int8') != dtype('bool')
FAILED csp/tests/test_type_checking.py::TestTypeChecking::test_runtime_type_check - AssertionError: TypeError not raised

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine timkpaine added lang: c++ Issues and PRs related to the C++ codebase tag: wip PRs that are a work in progress - converted to drafts labels Feb 14, 2024
@timkpaine timkpaine changed the title [WIP] attempt to reenable boolean vectors [WIP] clang - attempt to reenable boolean vectors Feb 14, 2024
@timkpaine
Copy link
Member Author

i have a third approach using a proxy for a bool type with implicit conversions

@timkpaine timkpaine closed this Feb 14, 2024
@timkpaine timkpaine deleted the tkp/clang2 branch February 19, 2024 23:41
@timkpaine timkpaine restored the tkp/clang2 branch March 7, 2024 13:32
@timkpaine timkpaine deleted the tkp/clang2 branch March 7, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang: c++ Issues and PRs related to the C++ codebase tag: wip PRs that are a work in progress - converted to drafts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants