Skip to content

Add binding and test for naked functions#2

Merged
kunaltyagi merged 3 commits intoPointCloudLibrary:masterfrom
kunaltyagi:gen_func
Oct 13, 2020
Merged

Add binding and test for naked functions#2
kunaltyagi merged 3 commits intoPointCloudLibrary:masterfrom
kunaltyagi:gen_func

Conversation

@kunaltyagi
Copy link
Copy Markdown
Member

@kunaltyagi kunaltyagi commented Oct 12, 2020 •
edited
Loading

Functions in some of their glory can get bound

@diivm
Copy link
Copy Markdown
Collaborator

diivm commented Oct 12, 2020

@kunaltyagi
Copy link
Copy Markdown
Member Author

kunaltyagi commented Oct 12, 2020 •
edited
Loading

What file are you working on?

pcl/common/centroid.h

Why do we need the parameter list?

So pybind can generate the names of the arguments

@kunaltyagi kunaltyagi requested a review from diivm October 12, 2020 15:54
diivm
diivm approved these changes Oct 13, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@diivm diivm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunaltyagi kunaltyagi merged commit 418a16b into PointCloudLibrary:master Oct 13, 2020
@kunaltyagi kunaltyagi deleted the gen_func branch October 13, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diivm diivm diivm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kunaltyagi @diivm