Make const usage better in function signatures

[kunaltyagi]

Context

clang-tidy has been used successfully before to make wide changes. We can use it to improve the API in the whole repo. We need discussion on the potential fix and just applying the other fixes after setting up clang-tidy.

Describe the solution you'd like

Apply the following fixes:

• remove const from return value type
• make member functions const
• add const to function parameters

Another potential fix:

• make some functions static members

[gnawme]

Related: #4560

[Prayag-raj-sharma]

I would like to work on it

[mvieth]

@Prayag-raj-sharma That's great! For your information: we now have a clang-tidy GitHub Action (.github/workflows/clang-tidy.yml), and the file .clang-tidy could also be relevant. You could start with const-return-type, then continue with the other checks. Please make sure your pull requests are not too large, otherwise please split them.

[Prayag-raj-sharma]

where to make changes can you elaborate, i/ have read all about clang-tidy just need to know where to make changes.

[mvieth]

@Prayag-raj-sharma You would add the check to .clang-tidy (twice, once for Checks and once for WarningsAsErrors). Then you create a pull request and fix all places where the GitHub Action complains.

[sibi-venti]

is it done? or can i work on it?

[Prayag-raj-sharma]

You can work on it

…

On Tue, 21 Nov, 2023, 2:41 pm sibi-venti, ***@***.***> wrote: is it done? or can i work on it? — Reply to this email directly, view it on GitHub <#3968 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUXBJ22AUDCICM5R3GFFSD3YFRV3VAVCNFSM4MO4JGI2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBSGA2TCMRXHAZA> . You are receiving this because you were mentioned.Message ID: ***@***.***>