Added SocketTransport wrapper class.#403
Merged
adamshapiro0 merged 2 commits intomasterfrom Apr 23, 2026
Merged
Conversation
bhers4
approved these changes
Apr 23, 2026
Contributor
bhers4
left a comment
bhers4
left a comment
There was a problem hiding this comment.
Looks good to me! Should make sure we don't double close a socket in the p1_capture tool by accident.
adamshapiro0
force-pushed
the
p1-capture
branch
from
6398722 to
dc61142
Compare
adamshapiro0
force-pushed
the
socket-transport
branch
4 times, most recently
from
336ce78 to
9938b43
Compare
adamshapiro0
force-pushed
the
socket-transport
branch
from
9938b43 to
796fac0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SocketTransportwrapper class to protect against multipleclose()calls