This repository was archived by the owner on Sep 23, 2025. It is now read-only.
Fix[DownloadUtils]: Set Read Timeout Duration#6504
Merged
Mathias-Boulay merged 2 commits intoPojavLauncherTeam:v3_openjdkfrom Apr 18, 2025
Merged
Fix[DownloadUtils]: Set Read Timeout Duration#6504Mathias-Boulay merged 2 commits intoPojavLauncherTeam:v3_openjdkfrom
Mathias-Boulay merged 2 commits intoPojavLauncherTeam:v3_openjdkfrom
Conversation
Pojav has not set a timeout for downloading files, which results in situations where file downloads do not throw an exception or terminate even after timing out.
Member
|
Looks good to me, not sure why this wasn't already handled properly. |
crystall1nedev
approved these changes
Apr 14, 2025
Mathias-Boulay
suggested changes
Apr 15, 2025
Contributor
Mathias-Boulay
left a comment
Mathias-Boulay
left a comment
There was a problem hiding this comment.
SocketTimeoutException inherits IOException, so it is already covered by the catch clause.
Mathias-Boulay
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pojav has not set a timeout for downloading files, which results in situations where file downloads do not throw an exception or terminate even after timing out.