Skip to content

Fix/item fixes#1389

Merged
Naramsim merged 5 commits intoPokeAPI:masterfrom
jemarq04:fix/item-fixes
Feb 3, 2026
Merged

Fix/item fixes#1389
Naramsim merged 5 commits intoPokeAPI:masterfrom
jemarq04:fix/item-fixes

Conversation

@jemarq04
Copy link
Contributor

@jemarq04 jemarq04 commented Feb 2, 2026

A lightweight PR to address the following issues:

This PR also replaced other instances of "é" used in identifiers for items with plain "e" and removed the other duplicate "acadaemy-___" items for the picnics in SV.

@jemarq04 jemarq04 marked this pull request as draft February 2, 2026 20:04
@jemarq04
Copy link
Contributor Author

jemarq04 commented Feb 2, 2026

A bit embarrassing that I didn't make sure it built first lol. Forgot to remove associated data with the duplicate items I removed!

@jemarq04 jemarq04 marked this pull request as ready for review February 2, 2026 20:25
@Naramsim
Copy link
Member

Naramsim commented Feb 2, 2026

Alright, so we shouldn't have é characters in any resource IDs.

@jemarq04
Copy link
Contributor Author

jemarq04 commented Feb 2, 2026

I know the apostrophe caused problems with the query, but the changes to é was mostly for consistency with other identifiers. I was definitely wary of bad responses with them, but I didn’t formally check that

@Naramsim
Copy link
Member

Naramsim commented Feb 2, 2026

I'll wait for GH to fix the issue with Actions and then merge: https://www.githubstatus.com/

@jemarq04
Copy link
Contributor Author

jemarq04 commented Feb 2, 2026

Of course, sounds good!

@Naramsim Naramsim merged commit 6f3e88c into PokeAPI:master Feb 3, 2026
9 of 16 checks passed
@jemarq04 jemarq04 deleted the fix/item-fixes branch February 3, 2026 14:23
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants