Add RSE Trades, remove non-zubat encounters from altering cave in Emerald#1478
Open
notblisy wants to merge 3 commits intoPokeAPI:masterfrom
Open
Add RSE Trades, remove non-zubat encounters from altering cave in Emerald#1478notblisy wants to merge 3 commits intoPokeAPI:masterfrom
notblisy wants to merge 3 commits intoPokeAPI:masterfrom
Conversation
This commit seeks to do two things: 1. Add all the trade encounters from this article: https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Generation_III into Ruby, Sapphire, and Emerald 2. Remove the non zubat altering cave encounters as described in this issue: PokeAPI#1457 To add the trades, I added a few things: - New location area for foretree city - relevant encounters and encounter slots - encounter conditions for which pokemon to trade - relevant prose To remove altering cave I: - Removed all non-zubat encounters from encounters.csv - Removed all hoenn altering cave location areas except 441, and removed its name "a". - removed relevant prose.
jemarq04
suggested changes
Apr 7, 2026
Contributor
|
Maybe we can wait before merging this one to give @ItsMeJoji some time to update their branch so it can be merged first to avoid #1476 from going stale again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit seeks to do two things:
Add all the trade encounters from this article: https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Generation_III into Ruby, Sapphire, and Emerald
Remove the non zubat altering cave encounters as described in this issue: Question: Should altering cave encounters be removed from FRLG/Emerald #1457
To add the trades, I added a few things:
New location area for foretree city
relevant encounters and encounter slots
encounter conditions for which pokemon to trade
relevant prose
To remove altering cave I:
Removed all non-zubat encounters from encounters.csv
Removed all hoenn altering cave location areas except 441, and removed its name "a".
removed relevant prose.
Contributor check list