fix: Rename region_id and base_form_id to region and base_form in evolution details#1487
Open
santichausis wants to merge 1 commit intoPokeAPI:masterfrom
Open
Conversation
Contributor
|
Looks like this PR includes contributions from your other PR regarding the main_generation field. Let's remove that from here to keep these separate |
santichausis
force-pushed
the
fix/evolution-chain-region-base-form
branch
from
317585d to
24b8ee9
Compare
…lution details For consistency with other fields (e.g. trade_species_id -> trade_species), evolution detail fields should omit the _id suffix. The serializer was manually naming them with _id, diverging from the documented API response. Fixes PokeAPI#1396
santichausis
force-pushed
the
fix/evolution-chain-region-base-form
branch
from
24b8ee9 to
4cdd1e8
Compare
Contributor
Author
Done, removed the main_generation changes — the PR now only includes the region/base_form rename. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency with other fields (e.g. trade_species_id → trade_species), evolution detail fields should omit the _id suffix. Updated both the serializer and openapi.yml. Fixes #1396