Skip to content

Fix unicity of flavor texts and version names#1490

Merged
Naramsim merged 7 commits intoPokeAPI:masterfrom
Dropries:fix-unicity
Apr 21, 2026
Merged

Fix unicity of flavor texts and version names#1490
Naramsim merged 7 commits intoPokeAPI:masterfrom
Dropries:fix-unicity

Conversation

@Dropries
Copy link
Copy Markdown
Contributor

@Dropries Dropries commented Apr 15, 2026

Change description

  • Ensure that each *_flavor_text.csv file contains a unique translation for each combination of *_id columns
  • Make the names of the Japanese "red" and "blue" versions unique + fix the Chinese name of the "white 2" version
  • Correct a typo issue caused by a unopened quotation mark

AI coding assistance disclosure

No AI coding has been used.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@Dropries Dropries marked this pull request as draft April 16, 2026 08:51
jemarq04
jemarq04 suggested changes Apr 16, 2026
View reviewed changes
Comment thread data/v2/csv/move_flavor_text.csv Outdated
Comment thread data/v2/csv/version_names.csv Outdated
@jemarq04
Copy link
Copy Markdown
Member

jemarq04 commented Apr 16, 2026

Just noticed this was a draft so maybe the review was premature lol. Feel free to continue working on this of course!

@Dropries Dropries marked this pull request as ready for review April 17, 2026 10:53
@Dropries Dropries requested a review from jemarq04 April 17, 2026 10:53
Dropries added 6 commits April 19, 2026 23:18
@Dropries
fix: remove quotation marks of Quaxly's flavor text in Scarlet
6bc43d3
@Dropries
fix chinese name of the white 2 version
58c87a5
@Dropries
feat: fix names of blue-japan and red-japan versions
bc4b095
@Dropries
fix: ensure that there is only one flavor text per combination of '*_…
ac1353f 
…id' columnsi

for moves : fix version_group_id of the descriptions from the teal mask
and the indigo disk

for abilities : remove the descriptions that does not correspond to the correct
version_group_id
@Dropries
minor fix
aac114b
@Dropries
Revert "feat: fix names of blue-japan and red-japan versions"
e7d673e 
This reverts commit 487bfa6.
@Naramsim Naramsim merged commit daf8f3c into PokeAPI:master Apr 21, 2026
9 checks passed
@Naramsim
Copy link
Copy Markdown
Member

Naramsim commented Apr 21, 2026

Thank you!

@pokeapi-machine-user
Copy link
Copy Markdown

pokeapi-machine-user commented Apr 21, 2026

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Apr 21, 2026
@pokeapi-machine-user
[Updater Bot] Regenerate data from PokeAPI/pokeapi#1490
ea6256d
@pokeapi-machine-user pokeapi-machine-user mentioned this pull request Apr 21, 2026
Merged
@pokeapi-machine-user
Copy link
Copy Markdown

pokeapi-machine-user commented Apr 21, 2026

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Apr 21, 2026
@pokeapi-machine-user
API data update from PokeAPI/pokeapi#1490`` (#362)
a35c2b9
@Dropries Dropries deleted the fix-unicity branch April 21, 2026 10:22
@codemonkey85 codemonkey85 mentioned this pull request Apr 21, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Naramsim Naramsim Naramsim approved these changes

+1 more reviewer

@jemarq04 jemarq04 jemarq04 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dropries @jemarq04 @Naramsim @pokeapi-machine-user