Remove all []() placeholders#1501
Conversation
0d6f5f0 to
c185a1d
Compare
|
hi @Dropries thanks for the PR. If you are willing to help again I'd like to remove all these We currently don't have any docs documenting it. It occurs only in some places, so I'd say it's time to remove it. It would be nice to re-do the work you've done by completely removing the placeholder and add only the right language wording. Then we could also remove the current logic that is now replacing the placeholder. Can you work on this? |
[]() placeholders
keep slug name for czech translations not referenced on bulbapedia
also remove the '$' and '%' characters around 'effect_chance' in 'move_effect_prose.csv'
e637c0d to
966a0d7
Compare
|
Done, there aren't any |
…eAPI#1502) * fix item pocket names * feat: add French male form name of frillish, jellicent and pyroar * fix: remove duplicated translations of Supersweet Syrup
v2 to rerun checks
966a0d7 to
320b0cc
Compare
|
Thank you! |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
Change description
This is a large stylistic PR that aims to ensure that the API return proses in a single language. When a prose contains
[]{a:b}, this pattern is replaced byb, which exists only in English, resulting in sentences mixing foreign languages and a single English wordb.In each
data/v2/csv/~_prose.csvfile, I replaced all empty square brackets of the form[]{a:b}by[c]{a:b}wherecis obtained from thedata/v2/csv/a_names.csvfile based on thelocal_language_idof the prose.A few German
[]{mechanic:b}are still empty because there is no file containing the translation of mechanics and I don't really know German...AI coding assistance disclosure
None
Contributor check list