Add sprites for type name icons#139
Merged
Naramsim merged 3 commits intoPokeAPI:masterfrom Mar 27, 2024
Merged
Conversation
Member
|
Hi! Thanks! Instead of using short-names for the folder, like FRGL, it would be better to use the name of the generation followed by another folder with the full name of the set as it's in our API. Such as: generation-i/red-blue/1.png We could also rename the images to use our internal IDs https://pokeapi.co/api/v2/type |
Remove type sprites that don't have a corresponding verison-group/version in Pokeapi
Contributor
Author
|
@Naramsim I've reorganized them as you've suggested. For version-groups that have the same type icons, I decided to just copy the sprites so each one would have a folder. Let me know if you have a preference to avoid this. I also just removed the folders that didn't have any associated version or version-groups in the API, such as Pokemon Stadium(2). |
Naramsim
approved these changes
Mar 27, 2024
This was referenced Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the files need for #137
Ripped from https://bulbapedia.bulbagarden.net/wiki/Type#Name_icons
Organized with subfolders named after the game of origin. Using the acronyms that the bulbapedia article uses.