FRLG RngHelper fixes#1178
Merged
Mysticial merged 4 commits intoPokemonAutomation:mainfrom Apr 15, 2026
Merged
Conversation
Mysticial
reviewed
Apr 15, 2026
|
|
||
|
|
||
| void check_timings(SingleSwitchProgramEnvironment& env, int64_t FIXED_SEED_OFFSET, const uint64_t& CONTINUE_SCREEN_DELAY, const uint64_t& INGAME_DELAY, bool SAFARI_ZONE); | ||
| void perform_blind_sequence(ProControllerContext& context, int64_t FIXED_SEED_OFFSET, const uint64_t& CONTINUE_SCREEN_DELAY, const uint64_t& TEACHY_DELAY, const uint64_t& INGAME_DELAY, bool SAFARI_ZONE); |
Collaborator
There was a problem hiding this comment.
Since these lines are so long, can you split them?
void perform_blind_sequence(
ProControllerContext& context,
int64_t FIXED_SEED_OFFSET,
const uint64_t& CONTINUE_SCREEN_DELAY,
const uint64_t& TEACHY_DELAY,
const uint64_t& INGAME_DELAY,
bool SAFARI_ZONE
);
Collaborator
|
Merging this as-is just to get it out. My comments can be applied to the next PR on these files. (since this won't be the last, lol) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes "hard" resets so that they are no longer performed blind. Yet to be tested with certain failure conditions (like update popups)
Also, this adds a dropdown for selecting different buttons to press on the title screen, since the ten-lines tool now includes seeds from the Start button as well as A