Another round of FRLG RNG updates#1251
Merged
Merged
Conversation
Mysticial
reviewed
May 20, 2026
| return "♂"; | ||
| case AdvGender::Female: | ||
| return "Female"; | ||
| return "♀"; |
Collaborator
There was a problem hiding this comment.
It'd generally not a good idea to put non-ascii characters in source files. Can you use an escape character? You can look in Pokemon_Strings.cpp.
Mysticial
reviewed
May 20, 2026
| modified_ingame_delay = timings.ingame_delay - 51430; | ||
| walk_to_safarizonewest(context); | ||
| use_sweet_scent(context, modified_ingame_delay, true); | ||
| return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a few changes based on some feedback from testers:
UserSetupErrorwhere appropriate... and also addresses a bug when trying to do wild RNG in Safari Zone West (reported by Sheep Punter)