Conversation
Palbolsky
approved these changes
Jan 22, 2025
AerunDev
approved these changes
Jan 22, 2025
Collaborator
AerunDev
left a comment
AerunDev
left a comment
There was a problem hiding this comment.
Tout fonctionne nickel, et aucune régression constatée, bien joué ! 😄
…of-creature-sprites-when-they-are-female-only-or-have-a-different-resource-for-females
AerunDev
deleted the
427-fix-a-bug-that-prevents-the-deletion-of-creature-sprites-when-they-are-female-only-or-have-a-different-resource-for-females
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the female sprites deletion in the resource tab of the Pokémon page.
The bug was due to the path falling back to the male sprite when the female couldn't be found.
I added a null check to avoid showing a big '?' when the JSON field is undefined.
closes #427
Tests to perform
Open the resource tab of a Pokémon that has different sprites for males and females (Butterfree, Sneasel, Venusaur, etc...)
Open the resource tab of a Pokémon that is female-only (Nidoqueen, Vespiquen, Salazzle, etc...)