Skip to content

Improve the quest UI earnings to allow users to customize egg or Pokémon earnings#437

Merged
AerunDev merged 7 commits intodevelopfrom
feature/improve-the-quest-ui-earnings
Feb 24, 2025
Merged

Improve the quest UI earnings to allow users to customize egg or Pokémon earnings#437
AerunDev merged 7 commits intodevelopfrom
feature/improve-the-quest-ui-earnings

Conversation

@Palbolsky
Copy link
Collaborator

@Palbolsky Palbolsky commented Jan 26, 2025

Description

This PR improves the quest UI earnings to allow users to more accurately select information about a Pokémon or egg.

The data structure has been adapted: we were using a dbSymbol, now an object. The object used is the same as the trainer's or group's creatures.

With the modification of the data structure, it's a breaking change for PSDK. Changes are required to support the functionality and avoid crashes.

Closes #38

Tests to perform

  • Add a Pokémon or egg quest reward ;
  • Edit a Pokémon or egg quest reward ;
  • Change a money reward (or other) to Pokémon or egg quest reward ;
  • Check if the data is correct in the json ;
  • Check that the migration works ;
  • Check the creatures of a group or a trainer can be managed correctly (no regression) ;
  • PSDK manages correctly the feature.

Tip

For the PSDK implementation, make sure to use the to_creature method to transform the Encounter data to Creature one.

Screenshot

image

@Palbolsky Palbolsky added User story Issues related to a new feature or request PSDK Issues that will need changes to Pokémon SDK game engine labels Jan 26, 2025
@Palbolsky Palbolsky self-assigned this Jan 26, 2025
@Palbolsky Palbolsky linked an issue Jan 26, 2025 that may be closed by this pull request
3 tasks
@Palbolsky Palbolsky force-pushed the feature/improve-the-quest-ui-earnings branch from a31580a to d8f417b Compare January 27, 2025 13:51
Copy link
Collaborator

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai pu tester toute la chaîne de Studio à PSDK, et ça fonctionne super bien. 😄
Bien joué pour l'implémentation !

@AerunDev
Copy link
Collaborator

Je mets une note ici, mais il faudra qu'on voit comment faciliter l'implémentation de la PR #378 de logicallyanime.

@AerunDev AerunDev changed the title Feature: Improve the quest UI earnings Improve the quest UI earnings to allow users to customize egg or Pokémon earnings Feb 24, 2025
@AerunDev AerunDev modified the milestone: Version 2.4.2 Feb 24, 2025
@AerunDev AerunDev merged commit 250f50d into develop Feb 24, 2025
2 checks passed
@AerunDev AerunDev deleted the feature/improve-the-quest-ui-earnings branch February 24, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PSDK Issues that will need changes to Pokémon SDK game engine User story Issues related to a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the quest UI earnings

3 participants