Conversation
3 tasks
a31580a to
d8f417b
Compare
AntoinePoree
approved these changes
Jan 27, 2025
AerunDev
approved these changes
Feb 24, 2025
Collaborator
AerunDev
left a comment
There was a problem hiding this comment.
J'ai pu tester toute la chaîne de Studio à PSDK, et ça fonctionne super bien. 😄
Bien joué pour l'implémentation !
Collaborator
|
Je mets une note ici, mais il faudra qu'on voit comment faciliter l'implémentation de la PR #378 de logicallyanime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the quest UI earnings to allow users to more accurately select information about a Pokémon or egg.
The data structure has been adapted: we were using a dbSymbol, now an object. The object used is the same as the trainer's or group's creatures.
With the modification of the data structure, it's a breaking change for PSDK. Changes are required to support the functionality and avoid crashes.
Closes #38
Tests to perform
Tip
For the PSDK implementation, make sure to use the
to_creaturemethod to transform the Encounter data to Creature one.Screenshot