Skip to content

Fixed a bug that forced users to click twice on the button to clear a text value in the text management pages#438

Merged
AerunDev merged 1 commit intodevelopfrom
430-fix-a-bug-with-the-clearinput-that-forces-the-user-to-double-click-to-clear-texts-in-some-conditions
Feb 2, 2025
Merged

Fixed a bug that forced users to click twice on the button to clear a text value in the text management pages#438
AerunDev merged 1 commit intodevelopfrom
430-fix-a-bug-with-the-clearinput-that-forces-the-user-to-double-click-to-clear-texts-in-some-conditions

Conversation

@Aelysya
Copy link
Collaborator

@Aelysya Aelysya commented Jan 27, 2025

Description

The bug was caused by the OnBlur event triggering before the OnClear event, setting the new text and updating the 'key' field of the component. The update of the 'key' field then forced the component to re-render, preventing the OnClear event from triggering.

closes #430

Tests to perform

Go to the Text Management page

  • Clearing a text without focusing an input still works properly
  • Entering or modifying a text and un-focusing the input still works properly
  • Entering text in an empty input and then trying to clear it without un-focusing now correctly clears it
  • Modifying a text and then trying to clear it without un-focusing now correctly clears it

@Aelysya Aelysya changed the title Fix a bug that forced users to click twice on the button to clear a text value in the text management pages Fixed a bug that forced users to click twice on the button to clear a text value in the text management pages Jan 27, 2025
@Aelysya Aelysya self-assigned this Jan 31, 2025
Copy link
Collaborator

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testé et approuvé ! Bien joué 😄

@AntoinePoree
Copy link
Collaborator

C'est bon pour moi aussi !

@AerunDev AerunDev merged commit 150984d into develop Feb 2, 2025
2 checks passed
@AerunDev AerunDev deleted the 430-fix-a-bug-with-the-clearinput-that-forces-the-user-to-double-click-to-clear-texts-in-some-conditions branch February 2, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix a bug with the ClearInput that forces the user to double click to clear texts in some conditions

3 participants