Conversation
3 tasks
AerunDev
approved these changes
Jan 31, 2025
Collaborator
AerunDev
left a comment
There was a problem hiding this comment.
C'est testé de mon côté, et ça fonctionne très bien ! Bien joué 😄
Collaborator
Author
|
Salut @NuriYuri, est-ce que tu pourrais me donner ton avis à propos de ce que j'ai fais dans le fichier |
Collaborator
|
Le code est plutôt OK, cela dit, il serait préférable que ça soit vraiment spécialisé pour l'entité Trainer histoire de pas trainer des as keyof T etc... Ca simplifiera aussi surement le code. Les fonctions qui font tout sont pas forcément bénéfiques ;) |
Collaborator
Author
|
Ca marche, je vais réécrire tout ça correctement. |
Palbolsky
requested changes
Feb 3, 2025
Palbolsky
approved these changes
Feb 3, 2025
AerunDev
approved these changes
Feb 3, 2025
Collaborator
AerunDev
left a comment
There was a problem hiding this comment.
J'ai refait des tests après les dernières modifications du code, et pour moi c'est toujours nickel, du coup on peut merge ! 😄
Bien joué !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The user can now create a new trainer by importing data from another existing trainer.
The imported data are:
closes #317
Tests to perform
Open the "New trainer" editor
Creating a new trainer without importing any data
Creating a new trainer by importing data