Skip to content

Fix types table responsiveness#446

Merged
AerunDev merged 1 commit intoPokemonWorkshop:developfrom
98teg:improve-types-table-responsiveness
Feb 24, 2025
Merged

Fix types table responsiveness#446
AerunDev merged 1 commit intoPokemonWorkshop:developfrom
98teg:improve-types-table-responsiveness

Conversation

@98teg
Copy link
Contributor

@98teg 98teg commented Feb 13, 2025

Thank you for your contribution to the Pokémon Studio repo.

Before submitting this PR into the develop branch, please make sure:

  • Your code builds clean without any errors or warnings
  • You are following the Code guidelines
  • You tested your code to make sure it does what it is supposed to do

Description

I tried implementing #62. Here are some screenshots to show the changes:

Before:
Before, type labels have moved to weird places

After:
After, everything is in place

Note before testing

None.

Tests to perform

  • Create some custom types.
  • Open the types table.
  • Shrink your window, and see if the table behaves correctly.

Copy link
Collaborator

@Palbolsky Palbolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you for the contributing. I approve the fix. 😄

Copy link
Collaborator

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution again! 🎉

@AerunDev AerunDev merged commit 22cd54f into PokemonWorkshop:develop Feb 24, 2025
@98teg 98teg deleted the improve-types-table-responsiveness branch February 25, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants