Implement event types using zod (v1)#482
Merged
Conversation
AntoinePoree
approved these changes
Apr 11, 2025
Collaborator
AntoinePoree
left a comment
AntoinePoree
left a comment
There was a problem hiding this comment.
J'ai demandé à copilot de m'aider à review du zod, vu que j'ai encore un peu de mal avec ><
Visiblement c'est solide, donc ce sera une bonne base pour les events 🥳
NuriYuri
approved these changes
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first iteration to implement the event types using zod.
The implementation is based of this issue: #453
Tests to perform
Nothing specific to test. Just check that I haven't written anything out of line with the information available.