Quest goals can be hidden by default#490
Merged
Conversation
AerunDev
approved these changes
Apr 15, 2025
Collaborator
AerunDev
left a comment
AerunDev
left a comment
There was a problem hiding this comment.
Testé et bien fonctionnel, gg ! 😄
Palbolsky
requested changes
Apr 16, 2025
src/views/components/database/quest/editors/goals/QuestGoalBeatNpc.tsx
Outdated
Show resolved
Hide resolved
src/views/components/database/quest/editors/goals/QuestGoalBeatNpc.tsx
Outdated
Show resolved
Hide resolved
src/views/components/database/quest/editors/goals/QuestGoalBeatNpc.tsx
Outdated
Show resolved
Hide resolved
src/views/components/database/quest/editors/goals/QuestGoalBeatNpc.tsx
Outdated
Show resolved
Hide resolved
src/views/components/database/quest/editors/goals/QuestGoalBeatNpc.tsx
Outdated
Show resolved
Hide resolved
src/views/components/database/quest/editors/goals/QuestGoalCustom.tsx
Outdated
Show resolved
Hide resolved
src/views/components/database/quest/editors/goals/QuestGoalEgg.tsx
Outdated
Show resolved
Hide resolved
src/views/components/database/quest/editors/goals/QuestGoalObtainItem.tsx
Outdated
Show resolved
Hide resolved
src/views/components/database/quest/editors/goals/QuestGoalSeePokemon.tsx
Outdated
Show resolved
Hide resolved
src/views/components/database/quest/editors/goals/QuestGoalSpeakTo.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@Palbolsky Tous les changements, on était fait 👍 |
Palbolsky
requested changes
Apr 23, 2025
src/views/components/database/quest/editors/QuestGoalEditor.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Done 👍 |
Palbolsky
approved these changes
Apr 23, 2025
Collaborator
Palbolsky
left a comment
Palbolsky
left a comment
There was a problem hiding this comment.
Parfait. J'approuve. 🥳
|
Properly updates the JSON file! |
# Conflicts: # assets/i18n/en/database_quests.json # assets/i18n/fr/database_quests.json # src/views/components/database/quest/editors/goals/QuestGoalCatchPokemon.tsx # src/views/components/database/quest/editors/goals/QuestGoalSeePokemon.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Put the toggle for the label hidden by default in quest objective editors. The data was already existing in the goalType.
Close #467
Tests to perform