Conversation
c97aca6 to
6117019
Compare
2536449 to
8e189ae
Compare
Collaborator
Author
|
J'ai testé la migration sur Linux et j'ai trouvé un bug que j'ai corrigé. Il faudrait s'assurer que tout est OK sur mac. |
AerunDev
approved these changes
Jul 9, 2025
Collaborator
There was a problem hiding this comment.
J'ai testé la plupart des fonctionnalités sur Windows, et tout semble bien plus fluide ! Le lancement en mode dev, la chargement des pages, le build avec npm run make également.
J'ai testé de créer un paquet et de le lancer, aucun problème également.
Bien joué, pour moi c'est validé ! 💪
Collaborator
Author
|
@pw-rey a validé le fonctionnement sur mac donc un dernier approuve et on peut merge :) |
Aelysya
approved these changes
Jul 11, 2025
AntoinePoree
approved these changes
Jul 11, 2025
8e189ae to
f947006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
webpackwithviteto improve application launch performance for developers. 🚀Many changes have been made, but they can easily be categorised as follows:
viteconfiguration: define the entries points of the application (main, preload and renderer), plugins and adujstment for the productionwebpackHot reload for the front end is functional, but not for the backend. For this to work in the backend, you would need to use
electron-vite. But we useelectron-forgewith aviteplugin because we usedelectron-forgewithwebpackplugin.Reloading for the backend didn't work with
webpackeither, so there's no regression.The update system and
psdk-binariesdepends onelectron-forge, so there are no problems to worry about.Closes #527
After merging this PR, you can delete the .webpack folder at the root of the project.
Performances gained
Dev environment (tested with i7-10700K and 32 GB ram) :
CI (github) :
Possible improvements
In dev, the time taken to launch the application depends enormously on the application's front-end (parsing, etc.).
I've done some tests with
react lazyand I can launch the application in 10 seconds. But this results in short loading times in the application (which is normal), but much less noticeable in production.So there's a balance to be struck to avoid impacting users. For this reason, I prefer to take the time to find a good compromise, but we can already merge this PR to already gain in performance.
Tests to perform