Skip to content

Add the moves contest database subpage#557

Merged
AerunDev merged 13 commits intodevelopfrom
547-add-the-moves-contest-database-subpage
Aug 28, 2025
Merged

Add the moves contest database subpage#557
AerunDev merged 13 commits intodevelopfrom
547-add-the-moves-contest-database-subpage

Conversation

@Aelysya
Copy link
Collaborator

@Aelysya Aelysya commented Aug 2, 2025

Description

This MR adds a new subpage to the moves database page to allow user to set their contest data.

closes #547

Tests to perform

  • Opening a pre-2.7.0 project correctly starts the migration
  • Switching between the subpages works
  • The migration correctly sets existing data to moves from generation 1 to 6
  • Other moves have contest data set to default values
  • The Main frame data can be edited
  • Modifying the description of one subpage doesn't modify the other one
  • Modifying the name works from both subpages
  • The main frame editor works
  • The data editor works
  • The contest effects editor works
  • The combo editor works
  • In the combo editor, setting any additional select to 'None' value removes the select
  • Importing combo moves from another moves works
  • Deleting one move form the combos works
  • Deleting all combo moves works
  • When creating a new move, you can choose a contest condition
  • When creating a new move and importing data, the contest condition you chose is kept

@Aelysya Aelysya self-assigned this Aug 2, 2025
@Aelysya Aelysya linked an issue Aug 2, 2025 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@Palbolsky Palbolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG pour le travail. J'ai trouvé des petites choses à corriger dont un crash.

  • Le tableau affichant les attaques combos crash si une attaque du tableau a été supprimée. (reproduction : supprimer l'attaque Relais et aller sur l'attaque Amnésie). Si l'attaque n'existe pas, simplement mettre "Attaque supprimée" en rouge et afficher aucune condition.
  • La condition de l'attaque "Clever" n'est pas traduit en français (je suppose que ça doit être Intelligence)
  • Typo : Description avancée de Enthousiasme bonus premier / dernier. "Si utilisé en premier / dernier...". Puisque "utilisé" fait référence à l'attaque, ça devrait être "utilisée".

Copy link
Collaborator

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello ! PR testée et approuvée ! 😄

Petite question pour être sûr : on peut ajouter Onde Folie à la liste des attaques qui feront des combos avec Onde Folie (donc la même attaque), on est OK avec ça ?

@Aelysya
Copy link
Collaborator Author

Aelysya commented Aug 28, 2025

Perso ça me choque pas.

@AerunDev AerunDev merged commit 6825e71 into develop Aug 28, 2025
5 checks passed
@AerunDev AerunDev deleted the 547-add-the-moves-contest-database-subpage branch August 28, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the moves Contest database subpage

3 participants