Add the moves contest database subpage#557
Merged
Conversation
3 tasks
Palbolsky
requested changes
Aug 28, 2025
Collaborator
There was a problem hiding this comment.
GG pour le travail. J'ai trouvé des petites choses à corriger dont un crash.
- Le tableau affichant les attaques combos crash si une attaque du tableau a été supprimée. (reproduction : supprimer l'attaque Relais et aller sur l'attaque Amnésie). Si l'attaque n'existe pas, simplement mettre "Attaque supprimée" en rouge et afficher aucune condition.
- La condition de l'attaque "Clever" n'est pas traduit en français (je suppose que ça doit être Intelligence)
- Typo : Description avancée de Enthousiasme bonus premier / dernier. "Si utilisé en premier / dernier...". Puisque "utilisé" fait référence à l'attaque, ça devrait être "utilisée".
Palbolsky
approved these changes
Aug 28, 2025
AerunDev
approved these changes
Aug 28, 2025
Collaborator
AerunDev
left a comment
There was a problem hiding this comment.
Hello ! PR testée et approuvée ! 😄
Petite question pour être sûr : on peut ajouter Onde Folie à la liste des attaques qui feront des combos avec Onde Folie (donc la même attaque), on est OK avec ça ?
Collaborator
Author
|
Perso ça me choque pas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MR adds a new subpage to the moves database page to allow user to set their contest data.
closes #547
Tests to perform